[Python-Dev] Socket/Asyncore bug needs attention

Armin Rigo arigo at tunes.org
Mon Sep 27 19:53:19 CEST 2004


Hello Raymond,

On Mon, Sep 27, 2004 at 12:35:07PM -0400, Raymond Hettinger wrote:
> Anyone who has worked on sockets or asyncore should take a look at SF
> bug #1010098:  CPU usage shoots up with asyncore.  (...)   If
> you worked on those modules, please review your check-ins to see if they
> were the cause:

Funnily enough, the check-in to blame is from you :-)  You replaced
asynchat.py's usage of fifo lists with collection.deque()s, but you overlooked
the test for emptiness, which was 'self.list == []'.  This is fine if
'self.list' is really a list, but not if it is a deque :-)

Fixed, checked in.


Armin


More information about the Python-Dev mailing list