[Python-Dev] [AST] Procedure for AST Branch patches

Brett C. bac at ocf.berkeley.edu
Tue Mar 22 15:24:26 CET 2005


Nick Coghlan wrote:
> Brett C. wrote:
> 
>> OK, thanks to John Ehresman here at PyCon sprint I got logistix's
>> patch applied.  Beyond a warning that a warning that decode_unicode()
>> is never called and the parser module failing to compile under Windows
>> everything should be fine for compiling the AST branch.
> 
> 
> Under Linux (Suse 9.1), the parser module compiles with a couple of
> warnings about implicit declaration of PyParser_SimpleParseString, but
> the .so fails to load due to a missing symbol PyNode_Compile.
> 

It's a known issue.  I am just ignoring the failed compile.

>> Passing the test suite, though, is another question.  =)
> 
> 
> Heh. I managed to get test_grammar to pass 100% last night, which is at
> least a start!
> 

Yeah, I am hoping to look at your generators patch before you get back in the
country.

> And I must say that the new system is rather nice to work with - it took
> me a while to work out what was going on, but the multi-pass 'build
> AST', 'build symbol table', 'compile AST' is much cleaner than it is
> with the lists-of-lists arrangement on the trunk (which is the entire
> point of the AST-branch, I guess. . .)
> 

How the system works will be *much* clearer with the new version of
Python/compile.txt, assuming everyone has not been lying to me about the clarity.

-Brett


More information about the Python-Dev mailing list