[Python-Dev] posixmodule.c patch- revision 43586

[Tim Peters]

[A.B., Khalid]
> According to MSDN, ShellExecute has only six parameters:
> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/reference/functions/shellexecute.asp
>
> But in the posixmodule patch at:
> http://mail.python.org/pipermail/python-checkins/2006-April/050698.html
>
> it is passed seven:
> """
> rc = ShellExecuteW((HWND)0, operation,
>   PyUnicode_AS_UNICODE(unipath),
>   PyUnicode_AS_UNICODE(woperation),
>   NULL, NULL, SW_SHOWNORMAL);
> """
>
>
> Shouldn't that part read as follows? Or am I missing something?
>
> """
> rc = ShellExecuteW((HWND)0,
>   PyUnicode_AS_UNICODE(woperation),
>   PyUnicode_AS_UNICODE(unipath),
>   NULL, NULL, SW_SHOWNORMAL);
> """

Well, _something's_ screwy with it.  All the Windows buildbots are
unhappy with that statement, giving 3 warnings:

\Code\python\Modules\posixmodule.c(7487) : warning C4133:
     'function' : incompatible types - from 'char *' to 'LPCWSTR'
\Code\python\Modules\posixmodule.c(7490) : warning C4047:
    'function' : 'INT' differs in levels of indirection from 'void *'
\Code\python\Modules\posixmodule.c(7490) : warning C4020:
     'ShellExecuteW' : too many actual parameters

It would be worse, except all the Windows buildbot compiles are dying
for a different reason:

md5c.c
c1 : fatal error C1083: Cannot open source file:
'\Code\python\Modules\md5c.c': No such file or directory

While we're at it, looks like all the 2.4 buildbots are failing
test_email today.