[Python-Dev] Twisted and Python 2.5a0r43587

[Neal Norwitz]

On 4/4/06, Thomas Wouters <thomas at python.org> wrote:
>
>
> On 4/4/06, Thomas Wouters <thomas at python.org> wrote:
> >
> >
> > Oh, goodie, a segmentation fault. Let's see if I can reproduce it ;P
>
>
> And so I could.
> test_banana.CananaTestCase.testCrashNegativeLong crashes,
> because it calls PyString_AsStringAndSize() with an int-ptr as second
> argument (an adjacent ptr variable becomes garbage.) That's certainly a
> problem with the Py_ssize_t change. Martin, aren't all output variables (or
> ptr-variables, rather) supposed to be controlled by the 'PY_SSIZE_T_CLEAN'
> #define? People aren't going to notice their compiler warnings; I know I
> didn't :)

I don't think so.  I think that macro controls Py_BuildValue etc (the
APIs in modsupport.h)  I don't think it controls anything else.  So
what that means is that Py_BuildValue("l") means something different
depending on ssize_t or not.

n