[Python-Dev] [Python-checkins] r45321 - in python/trunk: Lib/test/test_traceback.py Lib/traceback.py Misc/NEWS

[Georg Brandl]

Tim Peters wrote:
> [georg.brandl]
>> Author: georg.brandl
>> Date: Wed Apr 12 23:14:09 2006
>> New Revision: 45321
>>
>> Modified:
>>    python/trunk/Lib/test/test_traceback.py
>>    python/trunk/Lib/traceback.py
>>    python/trunk/Misc/NEWS
>> Log:
>> Patch #860326: traceback.format_exception_only() now prepends the
>> exception's module name to non-builtin exceptions, like the interpreter
>> itself does.
> 
> And all the trunk buildbot runs have failed since, in at least
> test_decimal, test_doctest and test_unpack.  Please run tests before
> checking in.

Well, it's tempting to let the buildbots run the tests for you <wink>
Honestly, I didn't realize that doctest relies on traceback. Running
the test suite takes over half an hour on this box, so I decided to
take a chance.

> The 2.4 backport of this patch should be reverted, since it changes
> visible behavior (for example, all the 2.4 branch buildbot runs also
> fail now).

Right. That's too much of a behavior change.

> Fine by me if we change the failing tests on the trunk to pass (noting
> that should have been done before checking in).

I'm not the one to decide, but at some time the traceback module should be
rewritten to match the interpreter behavior.

Cheers,
Georg