[Python-Dev] [Python-checkins] r45721 - python/trunk/Lib/test/test_with.py

[Nick Coghlan]

tim.peters wrote:
> Author: tim.peters
> Date: Wed Apr 26 03:15:53 2006
> New Revision: 45721
> 
> Modified:
>    python/trunk/Lib/test/test_with.py
> Log:
> Rev 45706 renamed stuff in contextlib.py, but didn't rename
> uses of it in test_with.py.  As a result, test_with has been skipped
> (due to failing imports) on all buildbot boxes since.  Alas, that's
> not a test failure -- you have to pay attention to the
> 
>     1 skip unexpected on PLATFORM:
>         test_with
> 
> kinds of output at the ends of test runs to notice that this got
> broken.

That would be my fault - I've got about four unexpected skips I actually 
expect because I don't have the relevant external modules built. I must have 
missed this new one joining the list.

> It's likely that more renaming in test_with.py would be desirable.

Yep. I can see why you deferred fixing it, though :)

I'm also curious as to why that test uses its own version of Nested rather 
than the one in contextlib. (granted, you can't inherit from the contextlib 
version, but containment should work fine)

Anyway, I've created SF bug #1476845 to keep track of the things that need to 
be done to finish the PEP 343 terminology cleanup. (What we have now should be 
fine for alpha 2)

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia
---------------------------------------------------------------
             http://www.boredomandlaziness.org