[Python-Dev] pychecker warnings in Lib/encodings

[Walter Dörwald]

Neal Norwitz wrote:

> All are missing parameters.  I'm not sure of the proper signature, so
> I didn't fix these:
> 
> Lib/encodings/punycode.py:217: No global (errors) found
> Lib/encodings/utf_8_sig.py:33: No global (errors) found
> Lib/encodings/uu_codec.py:109: No global (errors) found

Fixed in r46915 and r46917.

> IIUC (and I probably don't), mbcs is on windows only.  But should I be
> able to import encodings.mbcs on Linux or is this expected?
> 
>>>> import encodings.mbcs
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "Lib/encodings/mbcs.py", line 14, in <module>
>     class Codec(codecs.Codec):
>   File "Lib/encodings/mbcs.py", line 18, in Codec
>     encode = codecs.mbcs_encode
> AttributeError: 'module' object has no attribute 'mbcs_encode'

mbcs_encode() is compiled conditionally in Modules/_codecsmodule.c with
"#if defined(MS_WINDOWS) && defined(HAVE_USABLE_WCHAR_T)".

Should encodings/mbcs.py be made unimportable on non-Windows?

Servus,
   Walter