[Python-Dev] patch 1462525 or similar solution?
"Martin v. Löwis"
martin at v.loewis.de
Wed Nov 1 09:16:25 CET 2006
Paul Jimenez schrieb:
> I submitted patch 1462525 awhile back to
> solve the problem described even longer ago in
> and I'm wondering what my appropriate next steps are. Honestly, I don't
> care if you take my patch or someone else's proposed solution, but I'd
> like to see something go into the stdlib so that I can eventually stop
> having to ship custom code for what is really a standard problem.
The problem, as I see it, is that we cannot afford to include an
"incorrect" library *again*. urllib may be ill-designed, but can't
be changed for backwards compatibility reasons. The same should
not happen to urilib: it has to be "right" from the start.
So the question is: are you willing to work on it until it is right?
I just reviewed it a bit, and have a number of questions:
- Can you please sign a contributor form, from
and then add the magic words ("Licensed to PSF under
a Contributor Agreement.") to this code?
- I notice there is no documentation. Can you please come
up with a patch to Doc/lib?
- Also, there are no test cases. Can you please come up with
a test suite?
- Is this library also meant to support creation of URIs?
If so, shouldn't it also do percent-encoding, if the
input contains reserved characters. Also, shouldn't
it perform percent-undecoding when the URI contains
- Should this library support RFC 3987 also?
- Why does the code still name things "URL"? The RFC
avoids this name throughout (except for explaining
that the fact that the URI is a locator is really
More information about the Python-Dev