[Python-Dev] [Python-checkins] r52692 - in python/trunk: Lib/mailbox.py Misc/NEWS
barry at python.org
Thu Nov 9 16:07:23 CET 2006
-----BEGIN PGP SIGNED MESSAGE-----
On Nov 9, 2006, at 9:01 AM, A.M. Kuchling wrote:
> Should I backport this change to 2.5.1? Con: The patch adds two new
> internal functions, _sync_flush() and _sync_close(), so it's an
> internal API change. Pro: it's a patch that should reduce chances of
> data loss, which is important to people processing mailboxes.
> Because it fixes a small chance of potential data loss and the new
> functions are prefixed with _, my personal inclination would be to
> backport this change.
I agree. _ is a hint as to its non-publicness and I don't have a
problem in principle adding such methods. In this particular case,
it seems the patch improves reliability, so +1.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
-----END PGP SIGNATURE-----
More information about the Python-Dev