[Python-Dev] _PyGILState_NoteThreadState should be static or not?

Neal Norwitz nnorwitz at gmail.com
Mon Sep 11 10:34:21 CEST 2006


In Python/pystate.c, you made this checkin:

r39044 | mwh | 2005-06-20 12:52:57 -0400 (Mon, 20 Jun 2005) | 8 lines

Fix bug:  [ 1163563 ] Sub threads execute in restricted mode
basically by fixing bug 1010677 in a non-broken way.

_PyGILState_NoteThreadState is declared as static on line 54, but the
definition on line 508 is not static. (HP's cc is complaining.)  I
don't see this referenced in any header file, it seems like this
should be static?

$ grep _PyGILState_NoteThreadState */*.ch]
Python/pystate.c:static void _PyGILState_NoteThreadState(PyThreadState* tstate);
Python/pystate.c:               _PyGILState_NoteThreadState(tstate);
Python/pystate.c:       _PyGILState_NoteThreadState(t);
Python/pystate.c:_PyGILState_NoteThreadState(PyThreadState* tstate)


More information about the Python-Dev mailing list