[Python-Dev] whitespace normalization
steve at holdenweb.com
Wed Apr 25 15:39:26 CEST 2007
Duncan Booth wrote:
> "Neal Norwitz" <nnorwitz at gmail.com> wrote in
> news:ee2a432c0704242352w5a489a98sd1520427737dda6c at mail.gmail.com:
>> I just checked in a whitespace normalization change that was way too
>> big. Should this task be automated?
> IMHO, changing whitespace retrospectively in a version control system is a
> bad idea.
> How much overhead would it be to have a checkin hook which compares each
> modified file against the output of running reindent.py over the same file
> and rejects the checkin if it changes anything? (With of course an
> appropriate message suggesting the use of Reindent.py before reatttempting
> the checkin).
> That way the whitespace ought to stay normalized so you shouldn't need a
> separate cleanup step and you won't be breaking diff and blame for the
> sources (and if the reindent does ever break anything it should be more
Enforcing whitespace correctness on checkin has the added advantage that
we will be able to screw another 1% out of uncle Timmy, who will no
longer have to make his repeated whitespace correction checkins and will
therefore have time for more productive tasks.
Steve Holden +1 571 484 6266 +1 800 494 3119
Holden Web LLC/Ltd http://www.holdenweb.com
Skype: holdenweb http://del.icio.us/steve.holden
Recent Ramblings http://holdenweb.blogspot.com
More information about the Python-Dev