[Python-Dev] Python 2.5.1

[Khalid A. Bakr]

--- "Martin v. Löwis" <martin at v.loewis.de> wrote:

> Khalid A. Bakr schrieb:
> > 1. The bz2 archive ships with
> > \Modules\collectionsmodule.c instead of the
> > \Modules\_collectionsmodule.c used in the 2.5 SVN
> > branch. In fact the collectionsmodule.c was
> removed
> > some time ago.
> 
> Why do you say that?
> 
>
http://svn.python.org/projects/python/branches/release25-maint/Modules/collectionsmodule.c
> 
> is still present AFAICT.
> 
> > 2. If _collectionsmodule.c is the one to be used
> in
> > branch and source then it follows that
> \PC\config.c
> > needs an update.
> 
> But it isn't the one to be used.


I am sorry. Me repository seems corrupted. Doing a
clean check out of the 2.5 branch as I write this.


> That's true. Can you come up with a patch? Looking
> at the error code of the exception should be
> sufficient;
> it should be 5 (as the message shows). The exception
> is *not* a string, but an object.


Okay. It seems I mixed up WindowsError with the
exception e in my post; at least it is now known that
e is not a number. The patch is short and is as
follows:

Index: Lib/test/test_os.py
===================================================================
--- Lib/test/test_os.py	(revision 55014)
+++ Lib/test/test_os.py	(working copy)
@@ -245,7 +245,8 @@
             try:
                 os.stat(r"c:\pagefile.sys")
             except WindowsError, e:
-                if e == 2: # file does not exist;
cannot run test
+                # file may not exist, or access is
denied; cannot run test
+                if e.winerror == 2 or e.winerror ==
5:
                     return
                 self.fail("Could not stat
pagefile.sys")



Or do I need to submit this through sourceforge?


> That would indicate a bug in the MingW port.
>
> > If the same test passes in the official CPython on
> the
> > same machine (and it does), can it then be deduced
> > that this is not a system's issue but a compiler
> one?
> 
> Likely, neither nor. My guess is that the MingW
> port,
> for some reason, decides not to use the Win32 API to
> perform stat, but the C library. That is incorrect,
> as the C library will perform truncation of
> subsecond
> time stamps. The compiler itself should have no
> effect
> (other than defining different compiler recognition
> macros).
> 
> Regards,
> Martin
> 


I will try to check what can be done about this.

Regards,
Khalid

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com