[Python-Dev] Does Python/Python-ast.c need to be checked in?

Brett Cannon brett at python.org
Mon Feb 12 03:57:54 CET 2007


On 2/11/07, Guido van Rossum <guido at python.org> wrote:
> On 2/11/07, "Martin v. Löwis" <martin at v.loewis.de> wrote:
> > Actually, the regenerating should happen immediately after commit,
> > as this bumps the revision number of the asdl file. This means
> > you have to make two commits per AST grammar change: one to change
> > the grammar, and the other to update the regenerated file.
>
> Is this documented somewhere? It wouldn't hurt if there was a pointer
> to that documentation right next to the line in Python-ast.c that gets
> modified by the regeneration. (I've been wondering about this a few
> times myself.)
>

Don't think so.  How about this for wording for the file's documentation?

/*
   File automatically generated by %s.

   This module must be committed separately from each AST grammar change;
   the __version__ number is set to the revision number of the commit
   containing the grammar change.
*/

-Brett


More information about the Python-Dev mailing list