[Python-Dev] Adding timeout to socket.py and httplib.py

[Steven Bethard]

On 3/20/07, Facundo Batista <facundo at taniquetil.com.ar> wrote:
> So, I have two modifications to make to the patch:
>
> - change the name to "create_connection"
> - make timeout obligatory named
>
> Is everybody ok with this?

FWLIW, +1.  It was not immediately apparent to me that the third argument in::

    newsock = socket.create_connection(HOST, PORT, None)

is supposed to be a timeout.  The modified version::

    newsock = socket.create_connection(HOST, PORT, timeout=None)

is much clearer to me.


STeVe
-- 
I'm not *in*-sane. Indeed, I am so far *out* of sane that you appear a
tiny blip on the distant coast of sanity.
        --- Bucky Katt, Get Fuzzy