[Python-Dev] Adding timeout to socket.py and httplib.py - Updated

Georg Brandl g.brandl at gmx.net
Wed Mar 21 21:57:21 CET 2007


Facundo Batista schrieb:
> I updated the patch #1676823, reflecting discussion here:
> 
> - The function name changed, now it's _create_connection(). Its 
> signature also changed: now, timeout is mandatorily named.
> 
> - HTTPConnection has the posibility to call timeout with a number, and
> also with None. In both cases, it updates sock.timeout (changing
> effectively the default timeout).
> 
> Docs and tests cases are also updated (note: now there's no doc in
> libsocket.tex, as this function is now private).

Sorry that I didn't manage to review your earlier patch. As it seems, this
also had some benefits (the discussion that started on your inquiry).

There are others who can judge the new API and implementation better than
me, but I can review the formal issues as soon as the API is accepted.

Georg



More information about the Python-Dev mailing list