[Python-Dev] whitespace normalization pre-commit hook is giving me grief

[Brett Cannon]

On 5/26/07, Neal Norwitz <nnorwitz at gmail.com> wrote:
>
> On 5/26/07, Brett Cannon <brett at python.org> wrote:
> >
> >
> > On 5/25/07, Georg Brandl <g.brandl at gmx.net> wrote:
> > > Neal Norwitz schrieb:
> > > > On 5/25/07, Brett Cannon <brett at python.org> wrote:
> > > >> In my bcannon-objcap branch I am trying to check in a change that
> > involves a
> > > >> soft symlink from Lib/controlled_importlib.py to
> > > >> ../importlib/controlled_importlib.py through ``ln -s
> > > >> ../controlled_importlib.py controlled_importlib.py`` while in the
> Lib
> > > >> directory.  I have done this before in this branch so as to allow
> for
> > easy
> > > >> importing of code from the svn import of importlib that the branch
> > contains.
> > > >
> > > > I don't know that we've ever tested the commit hook with a link.
> > > > Maybe there is some other problem.
> > >
> > > The cause: For symlinks, SVN saves a file containing "link /target"
> and
> > sets
> > > the "svn:special" property. Since the special file doesn't end with a
> > newline,
> > > reindent adds that, and boom.
> > >
> > > The solution: add
> > >      if fs.node_prop(txn_root, path, 'svn:special') == '*': continue
> > >
> > > in the commit hook's for loop.
> >
> >
> > Great!  So can someone do this?  I don't know where the svn hook code is
> > stored, let alone whether I have access to commit a change.
>
> I made the change Georg suggested, give it a try.



Still failing.  I checked the added file for svn:special and it's set with
an '*' just like my other symlink.  And I double-checked the file by running
``python Tools/scripts/reindent.py -v Lib/controlled_importlib.py``  and it
said nothing had changed.

-Brett
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.python.org/pipermail/python-dev/attachments/20070526/b8e2565b/attachment.html