[Python-Dev] NeedsReview keyword

"Martin v. Löwis" martin at v.loewis.de
Tue Apr 15 22:45:58 CEST 2008

>     Just name your patch files .patch or .diff the next time, not .txt, and
>     the keyword will get automatically set.
> fine. I used .txt cause I wanted to view it in my browser (without the
> browser asking me for an application)

.diff would have done the same thing.

>     as it only affects the mmap module. I also don't see how this could
>     cause data loss if the application works correctly.
> the flush fails but the programs fails to recognize it? i.e. the program
> assumes the data is written to disk but it isn't?

Why would the program fail to recognize it? It should just look at the
result being returned.

I agree that this is fairly unpythonic, but I also think that there is
any data loss that this may cause is the application's fault.


More information about the Python-Dev mailing list