[Python-Dev] c99 comments in the 2.6 code base?

["Martin v. Löwis"]

>>> shouldn't we use a suitable gcc option for the buildbots to prevent that
>>> from happening?
>>
>> Which one specifically?
> 
> I suggest we add "-std=c89" to CFLAGS.

That needs thorough testing, in particular across many old Linux
distributions. It might be that some sets of Linux header files
rely on GNU C extensions, without using the __extension__ keyword.

> We could also add a new target
> called buildbot to the Makefile that appends "-std=c89 -Werror" to
> CFLAGS. I don't think it's wise to add "-Werror" to the standard build
> target. However a new build target with extra checks should help to
> detect errors much sooner.

That would need to go along with a policy that Python must never cause
GCC to emit any warnings.

Regards,
Martin