[Python-Dev] Test failures under Windows?

[Kristján Valur Jónsson]

Revision 70843.
I don't know when this crept in.  I didn't go and check if it applies to other branches too.

Also, I'm sorry for just checking this in witout warning.  But I had just spent what amounts to a full day tracking this down which was tricky because it happens in a subprocess and those are hard to debug on windows.  My eagerness got the best of me.

But again, it shows how useful assertions can be and why we ought not to disable them.

Cheers, 
Kristján
-----Original Message-----
From: Jesse Noller [mailto:jnoller at gmail.com] 
Sent: 31. mars 2009 22:00
To: Kristján Valur Jónsson
Cc: Curt Hagenlocher; mhammond at skippinet.com.au; David Bolen; python-dev at python.org
Subject: Re: [Python-Dev] Test failures under Windows?

Does it need to be backported? I wonder when that was introduced.
Also, what CL was it so I can review it?

2009/3/31 Kristján Valur Jónsson <kristjan at ccpgames.com>:
> I found a different problem in multiprocessing, for the py3k.
> In import.c, get_file.c, it was knowingly leaking FILE objects, while the underlying fh was being correctly closed.  This caused the CRT to assert when cleaning up FILE pointers on subprocess exit.
> I fixed this this afternoon in a submission to the py3k branch.
>
> K