[Python-Dev] Tweaking AST lineno and col_offset

[Frank Wierzbicki]

On Fri, Aug 14, 2009 at 3:11 PM, Benjamin Peterson<benjamin at python.org> wrote:
> 2009/8/14 Frank Wierzbicki <fwierzbicki at gmail.com>:
>> On Fri, Aug 14, 2009 at 12:16 PM, Benjamin Peterson<benjamin at python.org> wrote:
>>
>>>> I have a local patch that changes the CPython col_offset to match
>>>> Jython's, but before I submit a patch I thought I'd ask here if there
>>>> is support for this sort of change and if I should continue to find
>>>> col_offset and lineno results that look fishy to me, or should I just
>>>> change Jython's results to match (one way or another, things will be
>>>> much easier for me to test if they match).
>>>
>>> Yes, please submit it.
>> Great, the patch is here: http://bugs.python.org/issue6704
>
> I'll take a look.
>
>>
>>  BTW - I would have added a test to test_ast.py, but above the test
>> data it notes: #### EVERYTHING BELOW IS GENERATED ##### and I couldn't
>> find the tool used for the generation.  Does anyone know where that
>> is?
>
> It's at the bottom of the test file. :) You can add a handwritten test
> above that, though.
Heh -- how did I miss that :) ? -- I'll resubmit the patch with tests.

-Frank