[Python-Dev] speeding up PyObject_GetItem
Mike Klaas
mike.klaas at gmail.com
Wed Mar 25 06:13:41 CET 2009
On 24-Mar-09, at 3:15 PM, Raymond Hettinger wrote:
>
>> 4% on a micro-micro-benchmark is hardly compelling...
>
> I concur! This is utterly insignificant and certainly does
> not warrant removing the checks.
>
> -1 on these sort of fake optimizations. We should focus
> on algorithmic improvements and eliminating redundant
> work and whatnot. Removing checks that were put there for a reason
> doesn't seem useful at all.
To be fair, the main proposed optimization(s) would speed up the
microbenchmark by 15-25% (Daniel already stated that the NULL checks
didn't have a significant impact). This seems significant,
considering that tight loops whose cost is heavily due to array access
are common.
-Mike
More information about the Python-Dev
mailing list