[Python-Dev] r87010 - in python/branches/py3k: Doc/library/subprocess.rst Lib/subprocess.py Lib/test/test_subprocess.py

[Antoine Pitrou]

On Sat, 4 Dec 2010 23:17:49 +0000
Paul Moore <p.f.moore at gmail.com> wrote:
> On 4 December 2010 23:07, Paul Moore <p.f.moore at gmail.com> wrote:
> > Is there an issue on Windows? If not, and given how different FD
> > inheritance is on Windows, I'd argue that in the absence of bug
> > reports, there's no need to change behaviour on Windows.
> 
> Actually, from the error message I just got:
> 
> ValueError: close_fds is not supported on Windows platforms if you
> redirect stdin/stdout/stderr
> 
> So on Windows, for the issues mentioned (both of which involve
> redirected stdin/out/err), leaving the current default appears to be
> not only advisable, but required.
> 
> I suspect an os-dependent default would be ugly to document...

How about a best-effort behaviour? Setting close_fds to True would only
close fds where possible (i.e., not under Windows when piping either of
stdin, stdout, stderr).

Regards

Antoine.