[Python-Dev] [Python-checkins] r87118 - in python/branches/py3k: Mac/BuildScript/build-installer.py Makefile.pre.in

[Ned Deily]

In article <4CFE6DD1.9030801 at netwok.org>,
 Éric Araujo <merwok at netwok.org> wrote:
> > Author: ronald.oussoren
> > New Revision: 87118
> > Log: Two small changes to adjust framework builds to the new stable ABI
> > 
> > Modified: python/branches/py3k/Mac/BuildScript/build-installer.py
> > ============================================================================
> > ==
> > +    LDVERSION=None
> > +    VERSION=None
> > +    ABIFLAGS=None
> > +
> > +    with open(os.path.join(buildDir, 'Makefile')) as fp:
> > +        for ln in fp:
> > +            if ln.startswith('VERSION='):
> > +                VERSION=ln.split()[1]
> > +            if ln.startswith('ABIFLAGS='):
> > +                ABIFLAGS=ln.split()[1]
> > +
> > +            if ln.startswith('LDVERSION='):
> > +                LDVERSION=ln.split()[1]
> > +
> > +    LDVERSION = LDVERSION.replace('$(VERSION)', VERSION)
> > +    LDVERSION = LDVERSION.replace('$(ABIFLAGS)', ABIFLAGS)
> 
> Isn’t this a perfect use case for the new sysconfig module?

There is no guarantee which version of Python the build-installer script 
is being run with and, hence, no guarantee which version of sysconfig is 
available.  Typically it is an older system-supplied Python which is 
fine as it is merely used to run build-installer (which includes running 
Sphinx to build the documentation) and otherwise has no impact on the 
Python being built.

-- 
 Ned Deily,
 nad at acm.org