[Python-Dev] r87518 - python/branches/py3k/Parser/tokenizer.c

[Georg Brandl]

Am 28.12.2010 01:07, schrieb Victor Stinner:
> (oops, I posted an incomplete message, stupid mailer)
> 
> Le lundi 27 décembre 2010 à 22:22 +0100, Georg Brandl a écrit :
>> Am 27.12.2010 21:12, schrieb victor.stinner:
>> > Author: victor.stinner
>> > Date: Mon Dec 27 21:12:13 2010
>> > New Revision: 87518
>> > 
>> > Log:
>> > Issue #10778: decoding_fgets() decodes the filename from the filesystem
>> > encoding instead of UTF-8.
>> > 
> 
>> Hmm, and in case decoding fails, we return a Unicode error (without context)
>> instead of a syntax error?
> 
> Yes, but it is very unlikely. I don't see in which case the decoder can
> fail. But a memory error can occur.
> 
>> Doesn't seem like a good trade-off when the file name is just displayed in a message.
> 
> What do you suggest?

If the probability is so low, it's probably not worth changing.  I'm just
somewhat sensitive to changes that enforce correctness by taking away
useful information from the user.

Georg