[Python-Dev] Running Clang 2.7's static analyzer over the code base

Barry Warsaw barry at python.org
Tue May 4 04:34:13 CEST 2010


On May 03, 2010, at 10:12 PM, Steve Holden wrote:

>Antoine Pitrou wrote:
>> Le Mon, 03 May 2010 16:11:53 -0700, Brett Cannon a écrit :
>>> And in reply to Benjamin's question about the whitespace, I guess it
>>> actually doesn't matter. More important to clean up in py3k.
>> 
>> Would it be finally time to standardize all C files on a 4-spaces 
>> indentation rule?
>> 
>> I understand the "svn annotate" argument, but we edit code far more often 
>> than we annotate it. Also, it seems "svn ann -x -w" would ignore 
>> whitespace changes.
>> 
>Let's not forget to consider what Hg can do, since that represents the
>future.

Now would be a good time to convert the C files to 4 space indents.  We've
only been talking about it for a decade at least.  While I'm sure history can
be preserved across the svn->hg import, it's enough of a break to bite the
bullet and fix the code.  I think we only need to convert the py3k branch
though.

-Barry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/python-dev/attachments/20100503/b5697507/attachment.pgp>


More information about the Python-Dev mailing list