[Python-Dev] urlparse.urlunsplit should be smarter about +

John Arbash Meinel john.arbash.meinel at gmail.com
Sat May 8 18:04:47 CEST 2010


Stephen J. Turnbull wrote:
> David Abrahams writes:
>  > 
>  > This is a bug report.  bugs.python.org seems to be down.
>  > 
>  >   >>> from urlparse import *
>  >   >>> urlunsplit(urlsplit('git+file:///foo/bar/baz'))
>  >   git+file:/foo/bar/baz
>  > 
>  > Note the dropped slashes after the colon.
> 
> That's clearly wrong, but what does "+" have to to do with it?  AFAIK,
> the only thing special about + in scheme names is that it's not
> allowed as the first character.

Don't you need to register the "git+file:///" url for urlparse to
properly split it?

    if protocol not in urlparse.uses_netloc:
        urlparse.uses_netloc.append(protocol)

John
=:->



More information about the Python-Dev mailing list