[Python-Dev] Did I miss the decision to untabify all of the C code?

Mark Dickinson dickinsm at gmail.com
Sun May 9 15:54:06 CEST 2010


On Thu, May 6, 2010 at 4:52 AM, Joao S. O. Bueno <jsbueno at python.org.br> wrote:
> On Wed, May 5, 2010 at 9:59 PM, Eric Smith <eric at trueblade.com> wrote:
>> That's my point. Since it's basically unreviewable, is it smart to do it
>> during a beta?
>
> Hello folks -
> I don't think these modifications are that "unreviewable": the
> generated binaries have to be exactly the same with the untabified
> files don't they? So is a matter of stashing the binaries, applying
> the patches, rebuild and check to see if the binaries match. Any
> possible script defects undetected by this would be only (C code)
> indentation, which could be fixed later.

That's not foolproof, though:  there are lots of sections of code that
will only get compiled on certain platforms, or with certain configure
options, etc.

Mark


More information about the Python-Dev mailing list