[Python-Dev] Change to logging Formatters: support for alternative format styles

[Boštjan Mejak]

Line 31 (in Pastebin): _STYLE_CODES = tuple("% { $".split())

Is this really necessary? Why not
_STYLE_CODES = ('%', '{', '$')


On Tue, Oct 26, 2010 at 1:15 PM, Nick Coghlan <ncoghlan at gmail.com> wrote:

> On Tue, Oct 26, 2010 at 9:08 PM, Nick Coghlan <ncoghlan at gmail.com> wrote:
> > On Tue, Oct 26, 2010 at 12:28 AM, Vinay Sajip <vinay_sajip at yahoo.co.uk>
> wrote:
> >> Comments welcome. Assuming there are no strong objections asking for
> reversion
> >> of this change, I'll publicise to the wider community in a few days.
> >
> > It strikes me as a solid, pragmatic solution to a thorny problem.
> >
> > Looking at your checkin though, I wonder if it might be worth
> > implementing some little formatting style classes to get rid of the
> > if/elif chains from the Formatter code. Something like:
>
> Some syntax highlighting may make that wall-o'-code a little easier to
> read: http://pastebin.com/SG0Qr3r5
>
> Cheers,
> Nick.
>
> --
> Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> http://mail.python.org/mailman/options/python-dev/bostjan.mejak%40gmail.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20101026/216be986/attachment.html>