[Python-Dev] We should be using a tool for code reviews
Guido van Rossum
guido at python.org
Wed Sep 29 22:58:45 CEST 2010
On Wed, Sep 29, 2010 at 1:43 PM, Antoine Pitrou <solipsis at pitrou.net> wrote:
> Le mercredi 29 septembre 2010 à 13:35 -0700, Brett Cannon a écrit :
>> Well, we can start with strongly worded suggestions that patches
>> submitted using Rietveld will typically get priority over patches
>> submitted just to the issue tracker and that this means doing it from
>> a checkout.
> But will we (all of us) actually follow this rule?
> Granted, a patch is reviewed faster if it's easier to review. But in
> many cases (small patches) it doesn't really make a difference.
> I have from time to time suggested that a contributor post his/her patch
> to Rietveld. But that was for really large or nasty ones.
More use of the tool also increases accountability and provides more
opportunities for junior developers to learn. (And it increases
familiarity of all involved with the tool for the future.)
I agree it shouldn't be mandatory, but I would suggest you give it a
try even for small changes.
--Guido van Rossum (python.org/~guido)
More information about the Python-Dev