[Python-Dev] We should be using a tool for code reviews

Laurens Van Houtven lvh at laurensvh.be
Thu Sep 30 10:30:01 CEST 2010


On using code review tools: +1, no discussion.

I've recently been doing a bit of research on these as a side effect of
researching continuous deployment, so:
1. Barry is right about Launchpad's merge proposals (unsurprisingly)

2. hg has a review extension called hg-review, but I think it'll be too
difficult to use properly for a big dev team like Python's with many people
reading code reviews (hg-review stores reviews in the repository) -- there's
no real canonical way AFAIK of saying "give me all pending reviews
everywhere in the codebase", like you would have with a centralized place to
publish patches vs a specific revision.

(I *am* going to use hg-review personally for my startup, I'm not saying
it's a bad tool at all! Just that it's not very good for big teams yet,
because there's no real sensible way of getting a centralized UI for both
publishing and reviewing suggested patches.)

3. FWIW, I agree Rietveld's a better tool than ReviewBoard, and I'm not
attached to either of the authors, so Rietveld +1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20100930/a0de0adb/attachment.html>

More information about the Python-Dev mailing list