[Python-Dev] We should be using a tool for code reviews

Guido van Rossum guido at python.org
Thu Sep 30 16:56:59 CEST 2010


On Thu, Sep 30, 2010 at 7:52 AM,  <exarkun at twistedmatrix.com> wrote:
> On 02:47 pm, jnoller at gmail.com wrote:
>> Regardless of the tool(s) used, code reviews are a fantastic
>> equalizer. If you have long time, experienced developers "submitting"
>> to the same rules that newer contributors have to follow then it helps
>> remove the idea that there is special treatment occurring.
>
> Of course, this is only true if the core developers *do* submit to the same
> rules.  Is anyone proposing that current core committers have all their work
> reviewed before it is accepted?
>
> (I am strongly in favor of this, but I don't think many core committers
> are.)

Having worked in this style for almost 5 years now, I am also strongly
in favor. Jesse expressed it better than I could.

-- 
--Guido van Rossum (python.org/~guido)


More information about the Python-Dev mailing list