[Python-Dev] We should be using a tool for code reviews

Brett Cannon brett at python.org
Thu Sep 30 22:41:49 CEST 2010

On Thu, Sep 30, 2010 at 09:19, Georg Brandl <g.brandl at gmx.net> wrote:
> Am 29.09.2010 20:49, schrieb Guido van Rossum:
>> Unfortunately taking the average patch posted to the tracker and
>> importing it in Rietveld is very iffy -- it's very hard to find the
>> right branch+rev needed to be able to apply the patch correctly -- not
>> to mention that there are so many (slightly) different patch formats.
>> It would take a fair bit of AI to get this right.
>> The recommended way to work with Rietveld is to use a checkout
>> (fortunately with Hg this will become easier to do) and use the
>> "upload.py" script that you can download from Rietveld (log in and
>> click on the Create link).
> Then could we do it the other way round and let (our) upload.py open
> an issue with the patch automatically (after querying for information
> not already given to rietveld)?

Don't see why not, but those of us who use OpenID would need to start
caring about a password which would be unfortunate.


> Georg
> --
> Thus spake the Lord: Thou shalt indent with four spaces. No more, no less.
> Four shall be the number of spaces thou shalt indent, and the number of thy
> indenting shall be four. Eight shalt thou not indent, nor either indent thou
> two, excepting that thou then proceed to four. Tabs are right out.
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/brett%40python.org

More information about the Python-Dev mailing list