[Python-Dev] Rietveld or Review Board use?

[anatoly techtonik]

On Fri, Mar 4, 2011 at 9:53 PM, Andi Albrecht
<albrecht.andi at googlemail.com> wrote:
> On Fri, Mar 4, 2011 at 5:52 PM, Barry Warsaw <barry at python.org> wrote:
>> On Mar 04, 2011, at 05:19 PM, Victor Stinner wrote:
>>
>>>Le vendredi 04 mars 2011 à 10:05 -0600, skip at pobox.com a écrit :
>>>> Is Rietveld or Review Board being used within the Python core development
>>>> community?  I looked at the dev guide but didn't see anything obvious about
>>>> code reviews.  I don't see how to search the Rietveld instance at
>>>> codereview.appspot.com looking just for Python core review requests.
>>>>
>>>> My aim here is to provide some examples to a colleague at work.  I wanted to
>>>> give him some examples related to code with which I'm familiar.
>>>
>>>I used it at least twice.
>>>
>>>Issue #9425: http://codereview.appspot.com/1874048
>>>Issue #3080: http://codereview.appspot.com/3972045
>>
>> Yep, I used Rietveld for the PEP 3147/3149 patches and it was pretty nice.
>> It's not completely well integrated into our workflow, but it's cool enough
>> that I think we should promote it more.  Will that be easier once we're
>> permanently on Mercurial?
>
> FWIW there's a nice section in the contribution guidelines for the Go
> language about code reviews and how they integrate Rietveld into their
> development process: http://golang.org/doc/contribute.html#Code_review
> They're using a wrapper around the upload.py script bundled as a
> Mercurial extension.

Chromium uses tweaked upload.py script too.

> And IIRC there's already some Roundup integration done.

Yes, you should ask Martin about it. I believe he told about some
performance problems, but I don't remember if he tried to investigate
the source of the problem. Probably he doesn't have enough time.

-- 
anatoly t.