[Python-Dev] devguide: More miscellaneous review comments.

Michael Foord fuzzyman at voidspace.org.uk
Sun Mar 6 17:52:54 CET 2011


On 06/03/2011 13:14, Antoine Pitrou wrote:
> On Sun, 6 Mar 2011 21:58:24 +1000
> Nick Coghlan<ncoghlan at gmail.com>  wrote:
>
>> On Sun, Mar 6, 2011 at 7:37 PM, ned.deily<python-checkins at python.org>  wrote:
>>> http://hg.python.org/devguide/rev/ad3278cfc5f6
>>> changeset:   376:ad3278cfc5f6
>>> user:        Ned Deily<nad at acm.org>
>>> date:        Sun Mar 06 01:37:13 2011 -0800
>>> summary:
>>>   More miscellaneous review comments.
>>>
>>> files:
>>>   committing.rst
>>>   communication.rst
>>>   coredev.rst
>>>   faq.rst
>>>   stdlibchanges.rst
>>>
>>> diff --git a/committing.rst b/committing.rst
>>> --- a/committing.rst
>>> +++ b/committing.rst
>>> @@ -3,6 +3,9 @@
>>>   Committing and Pushing Changes
>>>   ==============================
>>>
>>> +.. TODO: include a checklist of items to be included in a commit?
>>> +   e.g updated Misc/NEWS entry, tests, doc
>> For non-Windows, get people to run "make patchcheck". Windows devs
>> will need a manual checklist, though.
> I find "make patchcheck" to be a poor tool and I would rather see
> a manual checklist than a suggestion to use "make patchcheck" (which I
> never use).

I find it helpful. Why do you say it is a "poor tool"?

Michael


> At least a manual checklist is able to explain you why
> the items are recommended.
>
> Regards
>
> Antoine.
>
>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/fuzzyman%40voidspace.org.uk


-- 
http://www.voidspace.org.uk/

May you do good and not evil
May you find forgiveness for yourself and forgive others
May you share freely, never taking more than you give.
-- the sqlite blessing http://www.sqlite.org/different.html



More information about the Python-Dev mailing list