[Python-Dev] hg diff

[Daniel Stutzbach]

On Antoine Pitrou <solipsis at pitrou.net> wrote:

> How do you review a branch?


Below is an example from github (because that's where my experience with
reviewing DCVS branches comes from), but I think it communicates the idea
well.

The user hsoft forked my blist project, made some changes, and sent me a
request to pull from his branch.  This is what I see:
https://github.com/DanielStutzbach/blist/pull/30/files

On Antoine Pitrou <solipsis at pitrou.net> wrote:

> You are assuming that I, as a
> reviewer, want to know about the history of changesets that led to the
> patch, but I don't: I want to read the patch as a cohesive whole, and I
> couldn't care less about the various typo fixes, style changes,
> performance tweaks that were checked in all along.
>

With a branch you can easily view the full patch, making a branch strictly
more general.

The advantage of having a branch comes when you want to review the second or
third iteration of a proposed change.  With a branch, you can view the diff
between the latest iteration and the branch point to view the change as a
cohesive whole.  Or you can view the diff between the latest iteration and
the last iteration you reviewed, to see if they have addressed your earlier
comments or not.

You can also just tweak a few things and push the changes back to them.
 They can easily merge your changes with any changes they've made in the
meantime (which is hard to do if you're pushing patch files around).

-- 
Daniel Stutzbach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20110307/d1df6566/attachment.html>