[Python-Dev] cpython (3.1): #2650: Refactor re.escape to use enumerate().

[Antoine Pitrou]

On Sat, 26 Mar 2011 15:00:29 -0400
Terry Reedy <tjreedy at udel.edu> wrote:
> On 3/26/2011 2:17 PM, Georg Brandl wrote:
> > "Refactor" doesn't sound like it belongs in the 3.1 branch...
> 
> >> -        for i in range(len(pattern)):
> >> -            c = pattern[i]
> >> +        for i, c in enumerate(pattern):
> 
> I would call thin 'Replace obsolete idiom in' rather than 'Refactor'.
> So are you criticizing the replacement or the mislabeling?

I think the criticism is that such gratuitous replacements in bugfix
branches are both a waste of time and a possible regression. The only
good reason to do them is if you think it will improve further merges
of bugfix patches.

Regards

Antoine.