[Python-Dev] [Python-checkins] cpython: Issue #12120, Issue #12119: tests were missing a sys.dont_write_bytecode check

Victor Stinner victor.stinner at haypocalc.com
Fri May 20 00:51:23 CEST 2011


Python 3.3 is not supposed to create .pyc files in the same directory
than the .py files. So I don't understand the following code.

Le jeudi 19 mai 2011 à 19:56 +0200, tarek.ziade a écrit :
> http://hg.python.org/cpython/rev/9d1fb6a9104b
> changeset:   70207:9d1fb6a9104b
> user:        Tarek Ziade <tarek at ziade.org>
> date:        Thu May 19 19:56:12 2011 +0200
> summary:
>   Issue #12120, Issue #12119: tests were missing a sys.dont_write_bytecode check
> 
> files:
>   Lib/distutils/tests/test_build_py.py         |  3 ++-
>   Lib/packaging/tests/test_command_build_py.py |  3 ++-
>   Misc/NEWS                                    |  3 +++
>   3 files changed, 7 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/Lib/distutils/tests/test_build_py.py b/Lib/distutils/tests/test_build_py.py
> --- a/Lib/distutils/tests/test_build_py.py
> +++ b/Lib/distutils/tests/test_build_py.py
> @@ -58,7 +58,8 @@
>          pkgdest = os.path.join(destination, "pkg")
>          files = os.listdir(pkgdest)
>          self.assertTrue("__init__.py" in files)
> -        self.assertTrue("__init__.pyc" in files)
> +        if not sys.dont_write_bytecode:
> +            self.assertTrue("__init__.pyc" in files)
>          self.assertTrue("README.txt" in files)
>  
>      def test_empty_package_dir (self):
> diff --git a/Lib/packaging/tests/test_command_build_py.py b/Lib/packaging/tests/test_command_build_py.py
> --- a/Lib/packaging/tests/test_command_build_py.py
> +++ b/Lib/packaging/tests/test_command_build_py.py
> @@ -61,7 +61,8 @@
>          pkgdest = os.path.join(destination, "pkg")
>          files = os.listdir(pkgdest)
>          self.assertIn("__init__.py", files)
> -        self.assertIn("__init__.pyc", files)
> +        if not sys.dont_write_bytecode:
> +            self.assertIn("__init__.pyc", files)
>          self.assertIn("README.txt", files)
>  
>      def test_empty_package_dir(self):
> diff --git a/Misc/NEWS b/Misc/NEWS
> --- a/Misc/NEWS
> +++ b/Misc/NEWS
> @@ -153,6 +153,9 @@
>  Library
>  -------
>  
> +- Issue #12120, #12119: skip a test in packaging and distutils
> +  if sys.dont_write_bytecode is set to True.
> +
>  - Issue #12065: connect_ex() on an SSL socket now returns the original errno
>    when the socket's timeout expires (it used to return None).
>  
> 
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins




More information about the Python-Dev mailing list