[Python-Dev] cpython: removed spurious output

[Georg Brandl]

On 30.05.2011 19:13, Tarek Ziadé wrote:
> On Mon, May 30, 2011 at 7:04 PM, Georg Brandl <g.brandl at gmx.net> wrote:
>> On 30.05.2011 17:54, Terry Reedy wrote:
>>>
>>>
>>> On 5/30/2011 6:25 AM, tarek.ziade wrote:
>>>
>>> Should not old_out be sys.stderr, since that is what you over-write and
>>> 'restore'?
>>>
>>>> +        old_out = sys.stdout
>>>> +        sys.stderr = StringIO()
>>>> +        try:
>>>> +            dist = self.run_setup('install_dist', '--prefix=' + self.root_dir)
>>>> +        finally:
>>>> +            sys.sterr = old_out
>>
>> And even more importantly, shouldn't this be "sys.stderr" instead of "sys..sterr"?
> 
> Yes,
> 
>>
>> Really, what happened to testing before you push?
> 
> I did test it, before and after my push, sir.
> 
> This was not to fix a test bug, but to avoid a spurious output in the tests.

Well, I assumed changing sys.stderr would be noticed as changing the execution
environment.

But as I've now found out, the test class itself cleans up sys.stderr, so you
couldn't have noticed the bug.  I apologize.

Georg