[Python-Dev] cpython (2.7): test_protocol_sslv2(): Skip this test if ssl.PROTOCOL_SSLv2 is not

[Antoine Pitrou]

On Mon, 31 Oct 2011 19:09:01 +0100
barry.warsaw <python-checkins at python.org> wrote:
> http://hg.python.org/cpython/rev/1de4d92cd6a4
> changeset:   73258:1de4d92cd6a4
> branch:      2.7
> parent:      73253:7ce3b719306e
> user:        Barry Warsaw <barry at python.org>
> date:        Mon Oct 31 14:08:15 2011 -0400
> summary:
>   test_protocol_sslv2(): Skip this test if ssl.PROTOCOL_SSLv2 is not
> defined (as is the case with Ubuntu 11.10).
> 
> files:
>   Lib/test/test_ssl.py |  2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
> --- a/Lib/test/test_ssl.py
> +++ b/Lib/test/test_ssl.py
> @@ -981,6 +981,8 @@
>          @skip_if_broken_ubuntu_ssl
>          def test_protocol_sslv2(self):
>              """Connecting to an SSLv2 server with various client options"""
> +            if not hasattr(ssl, 'PROTOCOL_SSLv2'):
> +                raise unittest.SkipTest('No SSLv2 available')
>              if test_support.verbose:
>                  sys.stdout.write("\n")
>              if not hasattr(ssl, 'PROTOCOL_SSLv2'):

I'm not sure, but I've think you've just committed a no-op.
(see http://hg.python.org/cpython/rev/5a080ebd311c)

Regards

Antoine.