[Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

Georg Brandl g.brandl at gmx.net
Wed Sep 21 18:16:58 CEST 2011


Am 21.09.2011 15:25, schrieb Ezio Melotti:

>> @@ -1205,6 +1214,18 @@
>>       minitemsize = 4
>>   tests.append(UnsignedLongTest)
>>
>> + at unittest.skipIf(not have_long_long, 'need long long support')
> 
> I think this would read better with skipUnless and s/have/has/:
> 
> @unittest.skipUnless(HAS_LONG_LONG, 'need long long support')

I don't think so. "skip if not" reads pretty well for me, while I
always have to think twice about "unless" -- may be a non-native-
speaker thing.

Georg



More information about the Python-Dev mailing list