[Python-Dev] unittest missing assertNotRaises
Michael Foord
fuzzyman at voidspace.org.uk
Wed Sep 28 13:04:06 CEST 2011
On 27/09/2011 19:46, Wilfred Hughes wrote:
> Hi folks
>
> I wasn't sure if this warranted a bug in the tracker, so I thought I'd
> raise it here first.
>
> unittest has assertIn, assertNotIn, assertEqual, assertNotEqual and so
> on. So, it seems odd to me that there isn't assertNotRaises. Is there
> any particular motivation for not putting it in?
>
> I've attached a simple patch against Python 3's trunk to give an idea
> of what I have in mind.
>
As others have said, the opposite of assertRaises is just calling the code!
I have several times needed regression tests that call code that *used*
to raise an exception. It can look slightly odd to have a test without
an assert, but the singular uselessness of assertNotRaises does not make
it a better alternative. I usually add a comment:
def test_something_that_used_to_not_work(self):
# this used to raise an exception
do_something()
All the best,
Michael Foord
> Thanks
> Wilfred
>
>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/fuzzyman%40voidspace.org.uk
--
http://www.voidspace.org.uk/
May you do good and not evil
May you find forgiveness for yourself and forgive others
May you share freely, never taking more than you give.
-- the sqlite blessing http://www.sqlite.org/different.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20110928/0c1198b8/attachment.html>
More information about the Python-Dev
mailing list