[Python-Dev] cpython (2.7): Issue #14448: mention pytz; patch by Andrew Svetlov

Sandro Tosi sandro.tosi at gmail.com
Wed Apr 25 10:21:48 CEST 2012


Hi Georg,
thanks for the review!

On Wed, Apr 25, 2012 at 09:37, Georg Brandl <g.brandl at gmx.net> wrote:
> On 24.04.2012 19:48, sandro.tosi wrote:
>> http://hg.python.org/cpython/rev/e0e421133d0f
>> changeset:   76532:e0e421133d0f
>> branch:      2.7
>> parent:      76527:22767284de99
>> user:        Sandro Tosi <sandro.tosi at gmail.com>
>> date:        Tue Apr 24 19:43:33 2012 +0200
>> summary:
>>   Issue #14448: mention pytz; patch by Andrew Svetlov
>>
>> files:
>>   Doc/library/datetime.rst |  8 ++++++++
>>   1 files changed, 8 insertions(+), 0 deletions(-)
>>
>>
>> diff --git a/Doc/library/datetime.rst b/Doc/library/datetime.rst
>> --- a/Doc/library/datetime.rst
>> +++ b/Doc/library/datetime.rst
>> @@ -1521,6 +1521,14 @@
>>  other fixed-offset :class:`tzinfo` subclass (such as a class representing only
>>  EST (fixed offset -5 hours), or only EDT (fixed offset -4 hours)).
>>
>> +.. seealso::
>> +
>> +   `pytz <http://pypi.python.org/pypi/pytz/>`_
>> +      The Standard Library has no :class:`tzinfo` instances except for UTC, but
>
>             ^^^^^^^^^^^^^^^^ we don't capitalize "standard library"
>
>> +      it exists a third-party library which brings Olson timezone database to
>
>         ^^ there                                    ^ the

sigh, you're right: I'll fix them once the below point is clarified

> Also, I'm not sure everybody knows what the "Olson database" is, so maybe that
> should be explained too.

I had considered that, but then I found another reference of "Olson
database" in an example right before the seealso note, so I left it as
it is. On a second thought, it might be better to clarify what Olson
db is, do you think a link (f.e to here:
http://www.iana.org/time-zones ) could be enough or (or in addition)
also a brief note is needed?

cheers,
-- 
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi


More information about the Python-Dev mailing list