[Python-Dev] cpython: Issue #14080: fix sporadic test_imp failure. Patch by Stefan Krah.

[Antoine Pitrou]

On Sun, 26 Feb 2012 16:18:54 -0500
Brett Cannon <brett at python.org> wrote:
> >
> > diff --git a/Lib/test/test_imp.py b/Lib/test/test_imp.py
> > --- a/Lib/test/test_imp.py
> > +++ b/Lib/test/test_imp.py
> > @@ -325,6 +325,7 @@
> >         self.addCleanup(cleanup)
> >         # Touch the __init__.py file.
> >         support.create_empty_file('pep3147/__init__.py')
> > +        importlib.invalidate_caches()
> >         expected___file__ = os.sep.join(('.', 'pep3147', '__init__.py'))
> >         m = __import__('pep3147')
> >         self.assertEqual(m.__file__, expected___file__, (m.__file__,
> > m.__path__))
> 
> 
> Should that just go into support.create_empty_file()? Since it's just a
> performance issue I don't see it causing unexpected test failures and it
> might help with any future issues.

I don't think adding import-specific workarounds in create_empty_file()
is a very good idea.
(I'm also not sure why that function exists)

Regards

Antoine.