[Python-Dev] [Python-checkins] cpython: Refactored logging rotating handlers for improved flexibility.

[Éric Araujo]

Hi,

> changeset:   57295c4d81ac
> user:        Vinay Sajip <vinay_sajip at yahoo.co.uk>
> date:        Wed Jan 04 12:02:26 2012 +0000
> summary:
>   Refactored logging rotating handlers for improved flexibility.

> diff --git a/Doc/howto/logging-cookbook.rst b/Doc/howto/logging-cookbook.rst
> --- a/Doc/howto/logging-cookbook.rst
> +++ b/Doc/howto/logging-cookbook.rst
> [snip]
> +These are not “true” .gz files, as they are bare compressed data, with no
> +“container” such as you’d find in an actual gzip file. This snippet is just
> +for illustration purposes.

I believe using the right characters for quote marks will upset Latex
and thus PDF generation, so the docs use ASCII straight quote marks.

> diff --git a/Doc/library/logging.handlers.rst b/Doc/library/logging.handlers.rst
> --- a/Doc/library/logging.handlers.rst
> +++ b/Doc/library/logging.handlers.rst
> [snip]
> +   .. method:: BaseRotatingHandler.rotation_filename(default_name)
> +
> +      Modify the filename of a log file when rotating.
> +
> +      This is provided so that a custom filename can be provided.
> +
> +      The default implementation calls the 'namer' attribute of the handler,
> +      if it's callable, passing the default name to it. If the attribute isn't
> +      callable (the default is `None`), the name is returned unchanged.

Should be ``None``.

Regards