[Python-Dev] test_hashlib

[Amaury Forgeot d'Arc]

2012/7/21 Antoine Pitrou <solipsis at pitrou.net>:
> Kristján Valur Jónsson <kristjan at ccpgames.com> wrote:
>>
>> The code will raise ValueError when int(1) is passed in, but the
>> unittests expect a TypeError.
>
> Well, if test_hashlib passes, surely your analysis is wrong, no?

In the normal case, yes:

>>> import hashlib
>>> hashlib.new(1)
TypeError: name must be a string

But if the _hashlib extension module is not available, the python
version is used and ValueError is raised:

>>> import sys
>>> sys.modules['_hashlib'] = None
>>> import hashlib
>>> hashlib.new(1)
ValueError: unsupported hash type 1

-- 
Amaury Forgeot d'Arc