[Python-Dev] Offer of help: http://bugs.python.org/issue10910

[Barry Scott]

On 24 Jun 2012, at 14:29, Martin v. Löwis wrote:

> On 24.06.2012 14:52, Barry Scott wrote:
>> I see that issue 10910 needs a reviewer for a patch.
>> 
>> I know the python code and C++ and offer to review
>> any patches to fix this issue.
> 
> Is this even an issue for 3.x? ISTM that the C library macros aren't
> used, anyway, so I think this entire section could go from the header
> files.

 $ grep isspace /Library/Frameworks/Python.framework/Versions/3.2/include/python3.2m/*.h
/Library/Frameworks/Python.framework/Versions/3.2/include/python3.2m/pyport.h:#undef isspace
/Library/Frameworks/Python.framework/Versions/3.2/include/python3.2m/pyport.h:#define isspace(c) iswspace(btowc(c))

I'm not familiar with pyport.h usage. I do see that it protects the problem lines with:
#ifdef _PY_PORT_CTYPE_UTF8_ISSUE

So long as that is not defined when C++ is in use no problem.

> 
> For 2.7, things are more difficult.

This is where a fix is required. Is there going to be another 2.7 release to deliver a fix in?

Barry