[Python-Dev] cpython (2.7): #9559: Append data to single-file mailbox files if messages are only added

[Antoine Pitrou]

On Thu, 28 Jun 2012 12:59:02 +0200
petri.lehtinen <python-checkins at python.org> wrote:
> http://hg.python.org/cpython/rev/c37cb11b546f
> changeset:   77832:c37cb11b546f
> branch:      2.7
> parent:      77823:73710ae9fedc
> user:        Petri Lehtinen <petri at digip.org>
> date:        Thu Jun 28 13:48:17 2012 +0300
> summary:
>   #9559: Append data to single-file mailbox files if messages are only added
> 
> If messages were only added, a new file is no longer created and
> renamed over the old file when flush() is called on an mbox, MMDF or
> Babyl mailbox.

Why so? Appending is not atomic and, if it fails in the middle, you
could get a corrupt mbox file.
Furthermore, I disagree that it's a bugfix: IMO it should wait for 3.4.

Regards

Antoine.