[Python-Dev] [Python-checkins] cpython (3.2): attempt to fix asyncore buildbot failure

[Jim Jewett]

What does this verify?

My assumption from the name (test_quick_connect) and the context (an
asynchronous server) is that it is verifying the server can handle a
certain level of load.  Refusing the sockets should then be a failure,
or at least a skipped test.

Would the below fail even if asyncore.loop were taken out of the
threading.Thread target  altogether?


On Fri, Mar 23, 2012 at 10:10 AM, giampaolo.rodola
<python-checkins at python.org> wrote:
> http://hg.python.org/cpython/rev/2db4e916245a
> changeset:   75901:2db4e916245a
> branch:      3.2
> parent:      75897:b97964af7299
> user:        Giampaolo Rodola' <g.rodola at gmail.com>
> date:        Fri Mar 23 15:07:07 2012 +0100
> summary:
>  attempt to fix asyncore buildbot failure
>
> files:
>  Lib/test/test_asyncore.py |  10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
>
>
> diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py
> --- a/Lib/test/test_asyncore.py
> +++ b/Lib/test/test_asyncore.py
> @@ -741,11 +741,15 @@
>
>         for x in range(20):
>             s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
> +            s.settimeout(.2)
>             s.setsockopt(socket.SOL_SOCKET, socket.SO_LINGER,
>                          struct.pack('ii', 1, 0))
> -            s.connect(server.address)
> -            s.close()
> -
> +            try:
> +                s.connect(server.address)
> +            except socket.error:
> +                pass
> +            finally:
> +                s.close()
>
>  class TestAPI_UseSelect(BaseTestAPI):
>     use_poll = False
>
> --
> Repository URL: http://hg.python.org/cpython
>
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>