[Python-Dev] cpython: Issue #14744: Fix compilation on Windows (part 2)

[Georg Brandl]

Am 30.05.2012 16:40, schrieb R. David Murray:
> On Wed, 30 May 2012 14:03:44 -0000, =?iso-8859-1?Q?Kristj=E1n_Valur_J=F3nsson?= <kristjan at ccpgames.com> wrote:
>> > -----Original Message-----
>> > From: python-dev-bounces+kristjan=ccpgames.com at python.org
>> > [mailto:python-dev-bounces+kristjan=ccpgames.com at python.org] On
>> > Behalf Of Georg Brandl
>> > Sent: 30. maí 2012 06:52
>> > To: python-dev at python.org
>> > Subject: Re: [Python-Dev] cpython: Issue #14744: Fix compilation on
>> > Windows (part 2)
>> > 
>> > Am 29.05.2012 18:54, schrieb victor.stinner:
>> > > http://hg.python.org/cpython/rev/df0144f68d76
>> > > changeset:   77231:df0144f68d76
>> > > user:        Victor Stinner <victor.stinner at gmail.com>
>> > > date:        Tue May 29 18:53:56 2012 +0200
>> > > summary:
>> > >   Issue #14744: Fix compilation on Windows (part 2)
>> > 
>> > All Windows buildbots are still failing the test suite, with an "invalid format
>> > string" ValueError, so I assume that is related to your string formatting
>> > speedups -- can you please have a look at it before I can tag the alpha?
>>
>> Curiously, the 64bit debug windows build cannot run the unittests either.
>> There are crash bugs in the release build and I wanted to repro it using the debug version , but failed.
>> This is likely to be related to the virtualenv changes, perhaps.
>> see http://bugs.python.org/issue14952
> 
> The "ValueError: Invalid format string" was coming from a
> broken-on-windows test_calendar test I checked in.  It is fixed now and
> the stable windows buildbots are green.

Indeed. Sorry Victor, bad David ;)

Georg