[Python-Dev] [Python-checkins] cpython: Make parameterized tests in email less hackish.

[R. David Murray]

On Thu, 31 May 2012 13:11:14 +1000, Nick Coghlan <ncoghlan at gmail.com> wrote:
> I'm not clear on why this is a metaclass rather than a simple class decorator.

Because I didn't think of it.  I don't (yet) think of "class" and
"decorator" in the same sentence :)

> On Thu, May 31, 2012 at 11:54 AM, r.david.murray
> <python-checkins at python.org> wrote:
> > + Â  Â In a _params dictioanry, the keys become part of the name of the generated
> > + Â  Â tests. Â In a _params list, the values in the list are converted into a
> > + Â  Â string by joining the string values of the elements of the tuple by '_' and
> > + Â  Â converting any blanks into '_'s, and this become part of the name. Â The
> > + Â  Â full name of a generated test is the portion of the _params name before the
> > + Â  Â '_params' portion, plus an '_', plus the name derived as explained above.
> 
> Your description doesn't match your examples or implementation.
> Assuming the example and implementation are correct (and they look
> more sensible than the currently described approach), I believe that
> last sentence should be:
> 
> "The  full name of a generated test is a 'test_' prefix, the portion
> of the test function name after the  '_as_' separator, plus an '_',
> plus the name derived as explained above."

Oops, yes.  Thanks for the catch.

--David